comparison configure @ 822:656b9133db24 draft

See commit b422ead31b077041cb030064008c6cd26ba058d0 for more info. /NNNC/somerandomnick> Why did you change configure to require bash? /relayhell/d3v11> you didn't see the commit message? /NNNC/somerandomnick> /relayhell/d3v11: not yet /NNNC/somerandomnick> /relayhell/d3v11: I was just looking at the diff. /NNNC/somerandomnick> /relayhell/d3v11: slackware doesn't even have a dash package available, so I'm not sure how pika managed to get himself that error. /relayhell/d3v11> if you want to change it back, go for it. /NNNC/somerandomnick> /relayhell/d3v11: I'd rather not start an edit war with you. /relayhell/d3v11> LOL if you change it back i won't rechange it /relayhell/d3v11> i made an executive decision because it gives a bunch of people shit. /NNNC/somerandomnick> The problem is caused by distributions that give people a bunch of shit. /NNNC/somerandomnick> "a bunch of shit" == sh pointing to a deliberately stripped down dash /relayhell/d3v11> right /NNNC/somerandomnick> sh should point to a useful default shell for users. /relayhell/d3v11> should but it doesn't always /NNNC/somerandomnick> really only in systems with upstart /NNNC/somerandomnick> and bash can do everything dash can do, so it's always safe to fix the distribution /NNNC/somerandomnick> "fix the distribution" == ln -s bash /bin/sh /relayhell/d3v11> if you think the change is problematic, then i welcome you rechanging it. /NNNC/somerandomnick> The change is problematic because it breaks any system that doesn't have bash.
author Nick <nick@somerandomnick.ano>
date Tue, 13 Dec 2011 04:12:07 +0000
parents f1f0ab9d41b7
children 5016f753b47a
comparison
equal deleted inserted replaced
821:8b12f44d3a37 822:656b9133db24
1 #!/bin/bash 1 #!/bin/sh
2 2
3 vars="gitd_ip gitd_basepath git_name git_email tinydns_config tinydns__rootsrvrname tinydns__rootsrvrip tinydns__tldsrvrname tinydns__tldsrvrip tinydns__srvrip tinydns__srvrname" 3 vars="gitd_ip gitd_basepath git_name git_email tinydns_config tinydns__rootsrvrname tinydns__rootsrvrip tinydns__tldsrvrname tinydns__tldsrvrip tinydns__srvrip tinydns__srvrname"
4 4
5 echo "Welcome to the resdb configurator!" >&2 5 echo "Welcome to the resdb configurator!" >&2
6 echo >&2 6 echo >&2
7
8 if ! echo "$var=${!var}" >/dev/null 2>&1; then
9 echo "Your shell sucks. If you're using a stupid OS like Ubuntu that doesn't" >&2
10 echo "give a damn about backwards compatibility, I'd suggest fixing your" >&2
11 echo "default shell, which you can do by typing \"ln -s bash /bin/sh\" at a" >&2
12 echo "root shell prompt." >&2
13 echo "If you have some ancient Unix system, I'd suggest installing bash." >&2
14 echo "If you have questions, you can always bother SRN :-)" >&2
15 exit 1
16 fi
7 17
8 for var in $vars ; do 18 for var in $vars ; do
9 export "$var"="$(cat conf/$var 2>/dev/null)" 19 export "$var"="$(cat conf/$var 2>/dev/null)"
10 done 20 done
11 if [ x"$gitd_basepath" = x ]; then 21 if [ x"$gitd_basepath" = x ]; then